----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107192/ -----------------------------------------------------------
(Updated Nov. 8, 2012, 12:47 p.m.) Review request for Plasma. Changes ------- -fixed tabbutton drawing when comicmodel count changed -implemented 'left to right' and 'top to bottom' direction Description (updated) ------- This patch is an attempt to port some part of comic plasmoid to QML. Most of the ported part are related to UI. The comic fetching logic are still in C++. In this patch, some features which related to changing applet size are removed. known problem: - tooltip to display additional text(the code is exist but still have problem). You can also try from rshah/comicqml branch. Diffs (updated) ----- applets/comic/CMakeLists.txt 91fa29f applets/comic/activecomicmodel.h PRE-CREATION applets/comic/activecomicmodel.cpp PRE-CREATION applets/comic/appearanceSettings.ui a153bf2 applets/comic/arrowwidget.h 64b1b36 applets/comic/arrowwidget.cpp 72d48ed applets/comic/buttonbar.h d4020bb applets/comic/buttonbar.cpp bb4dbef applets/comic/comic.h f5919df applets/comic/comic.cpp 3753eac applets/comic/comicwidgets.h 4320c58 applets/comic/configwidget.h e9d63c8 applets/comic/configwidget.cpp baddd45 applets/comic/fullviewwidget.h c0a1aff applets/comic/fullviewwidget.cpp fc78ba6 applets/comic/imagewidget.h 0825cfc applets/comic/imagewidget.cpp 9d36034 applets/comic/package/contents/ui/ButtonBar.qml PRE-CREATION applets/comic/package/contents/ui/ComicBottomInfo.qml PRE-CREATION applets/comic/package/contents/ui/ComicCentralView.qml PRE-CREATION applets/comic/package/contents/ui/FullViewWidget.qml PRE-CREATION applets/comic/package/contents/ui/ImageWidget.qml PRE-CREATION applets/comic/package/contents/ui/main.qml PRE-CREATION applets/comic/package/metadata.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107192/diff/ Testing ------- Tested the applet from my branch with other environment from master, seems working fine. There might be some missing features. Thanks, Reza Shah
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
