----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108115/#review24634 -----------------------------------------------------------
plasmate/savesystem/commitdialog.cpp <http://git.reviewboard.kde.org/r/108115/#comment18889> Do you really need to set modal true? Usually the modality is controlled by how the dialog is invoked. plasmate/savesystem/commitdialog.cpp <http://git.reviewboard.kde.org/r/108115/#comment18888> Use placeholderText for this text, no? Wow :) the code is looking much nicer now. Removing code feels right. ^^ Especially if you're not dropping functionality - Aleix Pol Gonzalez On Jan. 3, 2013, 8:13 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108115/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2013, 8:13 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hello, > > In this patch i am replacing the QDialogButtonBox with theQVBoxLayout. > Also i have increase the size of the dialog, because it was too small for the > labels. > > > Diffs > ----- > > plasmate/savesystem/commitdialog.cpp cf7cb1f > > Diff: http://git.reviewboard.kde.org/r/108115/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel