----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108255/#review25030 -----------------------------------------------------------
Tested and works perfect except for that 1px overlapping shadow issue I mentioned earlier but it now only appears in the last bits of the sliding out animation, and in the first bits of the sliding back in animation. - Kai Uwe Broulik On Jan. 9, 2013, 7:08 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108255/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2013, 7:08 a.m.) > > > Review request for kwin and Plasma. > > > Description > ------- > > Do not clip away shadows in SlidingPopupsEffect > > Animation now completely based on the expandedGeometry which includes the > shadows and another repaint at the end of the animation is added to > ensure that there are no leftover shadows. > > BUG: 312168 > FIXED-IN: 4.10 > REVIEW: 108255 > > > This addresses bug 312168. > http://bugs.kde.org/show_bug.cgi?id=312168 > > > Diffs > ----- > > kwin/effects/slidingpopups/slidingpopups.cpp > 5ffc56b392a833127a6f22a60c2da10ae50f4c06 > > Diff: http://git.reviewboard.kde.org/r/108255/diff/ > > > Testing > ------- > > I did some testing, but I would appreciate if a few more people could try the > patch and watch for rendering glitches. Sliding Popups has shown a huge > regression potential in the past, so we have to be extremely careful if we > want the patch in 4.10 > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
