----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108798/#review26738 -----------------------------------------------------------
Ship it! yes, all the camel case headers need to be converted so it can build in-framework now. (previously all this code was build in other repos after kdelibs, soooo.. :) - Aaron J. Seigo On Feb. 6, 2013, 5:56 a.m., Shawn Starr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108798/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 5:56 a.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Description > ------- > > Trying to build plasma-framework I encountered some headers using 3rd party > names vs internal and I believe these should all be internal headers? Fixing > those and commenting out one of the testcase apps gets it to build. Although > there's other issues with not linking kdecore/ui etc properly. Given this > code is in heavy development, you may disregard this review request but I'd > still like to go though the process. > > btw, I'm back ;) > > > Diffs > ----- > > scriptengines/qml/common/scriptenv.cpp b79cd3d > declarativeimports/core/framesvgitem.h fb4741a > scriptengines/qml/declarative/packageaccessmanager.h 3e9a712 > scriptengines/qml/declarative/packageaccessmanagerfactory.h 70e4eb9 > scriptengines/qml/plasmoid/abstractjsappletscript.h cdd709c > scriptengines/qml/plasmoid/appletauthorization.cpp 6fe9454 > scriptengines/qml/plasmoid/appletinterface.h 6226802 > scriptengines/qml/plasmoid/appletinterface.cpp f5dc187 > scriptengines/qml/plasmoid/declarativeappletscript.h 18b324b > scriptengines/qml/plasmoid/declarativeappletscript.cpp 75d25eb > shell/CMakeLists.txt ecbfad9 > > Diff: http://git.reviewboard.kde.org/r/108798/diff/ > > > Testing > ------- > > Able to build things, but didn't look into why proper KDE libraries not being > linked in yet (editing the generated CMakefiles/component.dir/link.txt works > around this for now) > > > Thanks, > > Shawn Starr > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
