----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108922/#review27508 -----------------------------------------------------------
Ship it! It seems correct to me. It would be interesting if you could run some interesting session with the ModelTest to catch this kind of issues ASAP, no? :) - Aleix Pol Gonzalez On Feb. 12, 2013, 3:10 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108922/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2013, 3:10 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Description > ------- > > Fix off-by-one error in RunnerModel > > The last argument of beginInsertRows() is the row number of the last > inserted row, not the one for the row after. > > > Diffs > ----- > > plasma/declarativeimports/core/runnermodel.cpp > ee1b54d45e02f1db8650219e08f6950d0e732a85 > > Diff: http://git.reviewboard.kde.org/r/108922/diff/ > > > Testing > ------- > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel