----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109444/ -----------------------------------------------------------
Review request for Plasma. Description ------- this makes ThemePrivate shared, so Theme instances can be created without relying on it to be a singleton. as is right now, by default a single "global" theme will be used. if instead a theme instance is created with a name as a parameter, that instance will be independent. useGlobalSettings should continue to decide where the configuration will be saved in plasmarc (config group as a property still to be implemented) The theme writing the config on the global or independent place is something actually independent from the "independent" instance of theme called with new Theme(themeName), so code may be made effectively simpler if that ctor is removed (and with that the themes hash in ThemePrivate): but this would also mean we will not ever try to have two themes in the same process (which may be a good thing, just have to be a decision.) Diffs ----- src/plasma/theme.h 4a28c74 src/plasma/theme.cpp 618d019 src/plasma/private/theme_p.cpp PRE-CREATION src/plasma/CMakeLists.txt a75d31c src/plasma/private/theme_p.h e8b5250 Diff: http://git.reviewboard.kde.org/r/109444/diff/ Testing ------- Thanks, Marco Martin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
