----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109500/#review29758 -----------------------------------------------------------
This review has been submitted with commit e12d0c1e3aaccf490788a47cb7b208ba1c9acc55 by Giorgos Tsiapaliokas to branch terietor/savesystem/APIv2. - Commit Hook On March 20, 2013, 6:16 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109500/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 6:16 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Hello, > > this patch is the refactor of the savesystem. > > Also in this refactor the above bugs are being fixed. > > Q: Why do we need a refactor? > A: * Before this patch in order to take the git log we did > some parsing, which wasn't nice. With this patch we use git log > --pretty-format. > * There are some other changes like coding style stuff and striping \n from > strings. > > > This addresses bugs 316202, 316724 and 316725. > http://bugs.kde.org/show_bug.cgi?id=316202 > http://bugs.kde.org/show_bug.cgi?id=316724 > http://bugs.kde.org/show_bug.cgi?id=316725 > > > Diffs > ----- > > plasmate/savesystem/dvcsjob.cpp 288d7a6 > plasmate/savesystem/gitrunner.h 50f87ab > plasmate/savesystem/gitrunner.cpp b263be6 > plasmate/savesystem/timeline.h 73849d0 > plasmate/savesystem/timeline.cpp 231fc46 > > Diff: http://git.reviewboard.kde.org/r/109500/diff/ > > > Testing > ------- > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
