----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109821/#review30695 -----------------------------------------------------------
Ship it! the only possible downside i can see at the moment is that it is not possible anymore to say which branch rename failed, etc. that does not really matter since the old code wasn't doing that either .. but it was possible with the individual jobs being returned. in future, if this becomes needed/desired, i suppose the signals in GitRunner could be augmented with additional information. in any case, this looks like an incremental improvement over the existing code as is. - Aaron J. Seigo On April 2, 2013, 6:24 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109821/ > ----------------------------------------------------------- > > (Updated April 2, 2013, 6:24 a.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch implements a proper KJob and uses the job as an async when > and where it makes sense. > > My opinion about the patch(feel free to ignore it:) > I tried to make all the jobs async but in some cases it was an overhead > and the code was looking bad, so I implemented the execSynchrousnly in order > to emphasize that the job is sync and to have a better result. > > > Diffs > ----- > > plasmate/savesystem/timeline.cpp 4293dae > plasmate/savesystem/timeline.h 95e7e97 > plasmate/savesystem/gitrunner.cpp 7520239 > plasmate/savesystem/gitrunner.h dfacc5b > plasmate/savesystem/dvcsjob.cpp 6f83307 > plasmate/savesystem/dvcsjob.h 38df371 > > Diff: http://git.reviewboard.kde.org/r/109821/diff/ > > > Testing > ------- > > I haven't found any regressions. > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
