----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109947/#review30888 -----------------------------------------------------------
This review has been submitted with commit ef2f99673c1e56086d68899003e190540e99565e by Aleix Pol to branch kde-telepathy-0.6. - Commit Hook On April 10, 2013, 10:47 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109947/ > ----------------------------------------------------------- > > (Updated April 10, 2013, 10:47 p.m.) > > > Review request for Plasma, Telepathy and David Edmundson. > > > Description > ------- > > This patch changes 2 things: > - changes the code from a js function to setting a qml property. This is > better because we don't have to connect to all the changing signals to > re-evaluate (there were some weird problems in this regard). > - Also it makes it so when you have a dialog opened, the status is set to > AcceptingInputStatus, this way the panel doesn't hide while you're writing. > This is useful because this way you can see if somebody talks to you while > you're chatting already. > > > Diffs > ----- > > chat/org.kde.ktp-chat/contents/ui/main.qml 9fb78c9 > > Diff: http://git.reviewboard.kde.org/r/109947/diff/ > > > Testing > ------- > > Self-conversation, as usual. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
