> On April 15, 2013, 7:32 a.m., Aaron J. Seigo wrote: > > Ship It! > > Frank Reininghaus wrote: > Just for the record, there is another request about this issue: > https://git.reviewboard.kde.org/r/109997/. See the discussion there for more > info. > > I think that the tinting is a very bad solution to highlight files, and I > think we should remove it in Dolphin.
Just for the record: I linked to that other review quest as well, so it's not like I am sneaking anything by here or so ... Let us know what you decide to do. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109995/#review31063 ----------------------------------------------------------- On April 15, 2013, 8:45 a.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109995/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 8:45 a.m.) > > > Review request for Plasma. > > > Description > ------- > > As of Dolphin 2.0, Dolphin tints the icons of selected file items by the > palette's highlight color. This patch adapts the Folder View icon view > rendering code to mirror this Dolphin behavior for consistency. > > A similar review request has been filed against KFileItemDelegate: > http://git.reviewboard.kde.org/r/109997/ > > I would like to apply this patch to both the KDE/4.10 and master branches. > > > Diffs > ----- > > plasma/applets/folderview/iconview.cpp 14c136e > > Diff: http://git.reviewboard.kde.org/r/109995/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Before > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/before.png > After > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/13/after.png > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
