----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110467/ -----------------------------------------------------------
Review request for Plasma. Description ------- Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo 1. The Xesam width and height properties are never returned by strigi and haven't been returned for a very very long time. It currently returns the nfo:width and nfo:height property instead. 2. KFileMetadataWidget is blocking and blocks while it is calculating the height and width. It is better to open the file and calculate it in another thread as done by the ImageSizeFinder 3. QImage in more reliable and actively maintained in contrast to strigi. Diffs ----- plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 Diff: http://git.reviewboard.kde.org/r/110467/diff/ Testing ------- Thanks, Vishesh Handa
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel