----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111621/#review36232 -----------------------------------------------------------
Ship it! Looks good in practice, thanks. - Eike Hein On July 20, 2013, 4:53 p.m., Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111621/ > ----------------------------------------------------------- > > (Updated July 20, 2013, 4:53 p.m.) > > > Review request for Plasma and Eike Hein. > > > Description > ------- > > The text label is rendered into a pixmap which can be smaller than the actual > text, because the item rect is inside some margins. > > This patch does two things: > - increase the pixmap size by 4 pixels on top and bottom > - fix the text positioning > > > This addresses bug 314879. > http://bugs.kde.org/show_bug.cgi?id=314879 > > > Diffs > ----- > > plasma/desktop/applets/tasks/support/textlabel.cpp 9fbc12d > > Diff: http://git.reviewboard.kde.org/r/111621/diff/ > > > Testing > ------- > > > Thanks, > > Christoph Feck > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
