----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112033/#review37635 -----------------------------------------------------------
This review has been submitted with commit f50a5412ba83058dcbfa3acff4b602cc87675d9a by Martin Gräßlin to branch master. - Commit Hook On Aug. 12, 2013, 5:34 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112033/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 5:34 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > Property windowId was according to the comments only provided because KWin > needed it. KWin's usecase was to know the window Id of the window where a > given item is rendered to. In QtQuick a QQuickItem provides a pointer to the > QQuickWindow holding the item. This means this hack is no longer needed. > > > Diffs > ----- > > src/declarativeimports/core/dialog.h 7392b71 > src/declarativeimports/core/dialog.cpp eaf3dce > > Diff: http://git.reviewboard.kde.org/r/112033/diff/ > > > Testing > ------- > > Yes, KWin's ThumnailItem is still working > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
