----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112105/#review37872 -----------------------------------------------------------
Ship it! Thanks for noticing this issue on KDE 4.11. Works fine on KDE 4.10 too. - Sinny Kumari On Aug. 15, 2013, 5:49 p.m., Shantanu Tushar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112105/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2013, 5:49 p.m.) > > > Review request for Plasma. > > > Description > ------- > > In KDE 4.11, if you do not parent a page after popping it from PageStack, it > will be deleted by QML's garbage collector. This creates erratic behavior > such as stopping playback the moment the user presses back from media player. > This patch reparents the page to the root element (and hides it) to prevent > the deletion. > > > Diffs > ----- > > shells/newshell/package/contents/ui/mediacenter.qml 28ae8e6 > > Diff: http://git.reviewboard.kde.org/r/112105/diff/ > > > Testing > ------- > > Doesn't seem to affect any workflow. Things to look out are weird placements > of the media elements (browser, player etc) due to the reparenting while > going back/into some mode. > > > Thanks, > > Shantanu Tushar > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
