> On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote: > > experimental/kdeclarative/bindings/backportglobal.h, line 24 > > <http://git.reviewboard.kde.org/r/113086/diff/1/?file=193824#file193824line24> > > > > backportglobal should be not needed anymore since we don't have > > qscriptengine anymore (needs to be tested tough)
Note that QtScript is still a dependency of the module. > On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote: > > experimental/kdeclarative/bindings/i18n.cpp, line 31 > > <http://git.reviewboard.kde.org/r/113086/diff/1/?file=193825#file193825line31> > > > > this file (probably the bindings folder too) could go as well I don't think I have the authority to remove anything. Also note that we're supposed to be backwards compatible, at least to some extent... - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41220 ----------------------------------------------------------- On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113086/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2013, 8:02 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdelibs > > > Description > ------- > > Reorganizes the file structure as the KF5 module suggest. > Adopts newer syntaxes for defining dependencies. > > > Diffs > ----- > > CMakeLists.txt 3204c11 > experimental/CMakeLists.txt e73a8c4 > experimental/COPYING 5185fd3 > experimental/COPYING.LIB 2d2d780 > experimental/CTestConfig.cmake c383ee1 > experimental/KDELibsExperimentalNightly.cmake fd53e0c > experimental/kdeclarative/CMakeLists.txt 72ea7a2 > experimental/kdeclarative/bindings/backportglobal.h fca8ade > experimental/kdeclarative/bindings/i18n.cpp 75a67aa > experimental/kdeclarative/bindings/i18n_p.h > experimental/kdeclarative/bindings/icon.cpp dbdc8fe > experimental/kdeclarative/bindings/qscriptnonguibookkeeping.cpp 919e889 > experimental/kdeclarative/bindings/url.cpp 3031a6f > experimental/kdeclarative/config-kdeclarative.h.cmake 611c678 > experimental/kdeclarative/configpropertymap.h c9ef3ae > experimental/kdeclarative/configpropertymap.cpp 373a655 > experimental/kdeclarative/kdeclarative.h > experimental/kdeclarative/kdeclarative.cpp 63ae180 > experimental/kdeclarative/kdeclarativeConfig.cmake.in d68008a > experimental/kdeclarative/kdeclarativeConfigVersion.cmake.in eae2225 > experimental/kdeclarative/private/kdeclarative_p.h > experimental/kdeclarative/private/kiconprovider.cpp 8506b8b > experimental/kdeclarative/private/kiconprovider_p.h > experimental/kdeclarative/private/rootcontext.cpp > experimental/kdeclarative/private/rootcontext_p.h > experimental/kdeclarative/qmlobject.h > experimental/kdeclarative/qmlobject.cpp ee81b41 > experimental/kdeclarative/qmlobject_p.h > experimental/kdeclarative/test/test.cpp 3986b77 > experimental/kdeclarative/test/test.qml 060c265 > experimental/kdeclarative/test/testobject_p.h > staging/CMakeLists.txt 5c5c80c > staging/kdeclarative/CMakeLists.txt PRE-CREATION > staging/kdeclarative/KDeclarativeConfig.cmake.in PRE-CREATION > staging/kdeclarative/src/CMakeLists.txt PRE-CREATION > staging/kdeclarative/tests/CMakeLists.txt PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113086/diff/ > > > Testing > ------- > > Builds. > There's a test that tests things that are not part either of this module or > its dependencies: > > import Qt 4.7 > import org.kde.plasma.core 0.1 as PlasmaCore > import org.kde.plasma.graphicswidgets 0.1 as PlasmaWidgets > > I'm unsure what to do with those. (can do in a further commit, we're not > moving the module to its tier yet) > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
