----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113447/#review42433 -----------------------------------------------------------
Ship it! this is also a pretty bad hack because it will cause all usages of this on files that *should* be merged to exhibit strange behaviour. however, that is not how it is used in libplasma, so having this hack is preferable to having broken config updates. for KF5, this points to how kconfig needs work -> it should be possible to retrieve the OpenFlags that were used to create it; reparse should *not* cause a sync() just to re-read values from disk, values on disk that have changed should override the values set in the config object and life should continue on as expected. that a *read* action causes a *write* is completely unexpected from an application API POV. - Aaron J. Seigo On Oct. 27, 2013, 12:19 p.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113447/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2013, 12:19 p.m.) > > > Review request for kdelibs and Plasma. > > > Repository: kdelibs > > > Description > ------- > > Please see https://git.reviewboard.kde.org/r/113443/ for the earlier attempt > and Aaron's review, which lead to this new take. > > > Diffs > ----- > > plasma/configloader.cpp 6e97cb9 > > Diff: http://git.reviewboard.kde.org/r/113447/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
