----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113471/#review42444 -----------------------------------------------------------
Ship it! not pretty, but it works. one small code issue below that should be fixed before pushing. cheers .. plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml <http://git.reviewboard.kde.org/r/113471/#comment30810> missing {}s (even one-liners get them) - Aaron J. Seigo On Oct. 27, 2013, 10:36 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113471/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2013, 10:36 a.m.) > > > Review request for kde-workspace, Plasma, Àlex Fiestas, and Michael Zanetti. > > > Bugs: 311871 > http://bugs.kde.org/show_bug.cgi?id=311871 > > > Repository: kde-workspace > > > Description > ------- > > Reading https://bugs.kde.org/show_bug.cgi?id=311871#c41 you can see that it > happens that we are doing a > #78 0x00007f4eff8c5ffb in QDeclarativeListModel::insert (this=0x1ebbdb0, > index=0, valuemap=...) at util/qdeclarativelistmodel.cpp:436 > and then we end up reentring and doing > #16 0x00007f4eff8c737f in QDeclarativeListModel::remove (this=0x1ebbdb0, > index=6) at util/qdeclarativelistmodel.cpp:402 > > Some of the stuff that depends on the QDeclarativeListModel doesn't seem to > like getting a "remove" while a "insert" is happening and to be honest m in > no mood to fix that, so basically I'm protecting against that happening in > our QML code. From what i read you have to be extremely unlucky since the > timer only triggers each 10 minutes and it has to trigger at the same time a > notification is being added, but oh well, the backtrace points to it and two > different people in two different systems say it has stopped the crashes so I > don't think it hurts to have this in. > > > Diffs > ----- > > > plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml > bf33eb1 > plasma/generic/applets/notifications/contents/ui/Notifications.qml 114ead2 > > Diff: http://git.reviewboard.kde.org/r/113471/diff/ > > > Testing > ------- > > I can't reproduce it in my desktop but Alex and Michael have been running > this patch for weeks and can certainly say that the crashing situation has > improved (i.e. no crashes in days with this patch and crashes daily without > it). > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
