> On Nov. 25, 2013, 3:19 p.m., Marco Martin wrote:
> > I'm not really the reviewer for it, but just my 2 cents:
> > 
> > that's pretty much the reason why at the beginning of the project (a lot of 
> > years ago by now;) we wanted the possibility to have plasmoids around in 
> > the media center.
> > 
> > Just hardcoding the time, while seems easy to do, opens a can of worms 
> > since being 12h or 24 h must have to depend from the system settings, then 
> > many will want it, many will not want it, then someone may want to have the 
> > date too.. and that pretty much duplicates the clock plasmoid featuers ;)

Goes without saying, that is the right way (TM). Once Plasma2 is out, plasmoids 
will be back :) We can haz shiny digital clock then \o/


- Shantanu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114110/#review44424
-----------------------------------------------------------


On Nov. 25, 2013, 3:12 p.m., Oskar Jauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114110/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 3:12 p.m.)
> 
> 
> Review request for Plasma and Shantanu Tushar.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Shows time in the lower right corner in 12 hours format in the Plasma 
> MediaCenter.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediawelcome/HomeScreenHeader.qml 2127ce7 
>   mediaelements/mediawelcome/HomeScreenFooter.qml e6173de 
> 
> Diff: http://git.reviewboard.kde.org/r/114110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oskar Jauch
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to