> On Dec. 16, 2013, 7:16 p.m., Sebastian Kügler wrote: > > plasmoidviewer/CMakeLists.txt, line 22 > > <http://git.reviewboard.kde.org/r/114493/diff/2/?file=225327#file225327line22> > > > > Please make this org.kde.plasma.plasmoidviewershell, we're moving > > everything from org.kde.* to org.kde.plasma.* > > Bhushan Shah wrote: > @sebas If you don't mind can we install it to > org.kde.plasmate.plasmoidviewershell? (Given this is not plasma stuff > actually) > > Sebastian Kügler wrote: > That's fine with me. > > Giorgos Tsiapaliokas wrote: > IMO we should avoid the name plasmate into the QML import name. > The name "plasmate" refers to the ide and the repository. I *really* want > to make clear > even from the QML imports that plasmate doesn't try to take any distance > from plasma. > So how would we name it, if it was kickoff or rssnow or slc?
I am not telling to install QML imports; reason behind naming it such is to avoid confusion between shells that kde-workspace installs and are usable to users and shell that is used in plasmate plasmoidviewer as it is special case. - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114493/#review45779 ----------------------------------------------------------- On Dec. 16, 2013, 6:06 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114493/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 6:06 p.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > This is a merge request for plasmoidviewer2 branch into the frameworks branch. > > Plasmoidviewer2 branch contains some missing features and bug fixes. > > > Diffs > ----- > > plasmoidviewer/CMakeLists.txt 30de8e2 > plasmoidviewer/fullview.h 7d4c70d > plasmoidviewer/fullview.cpp 898931a > plasmoidviewer/main.cpp f3cdb22 > plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60 > plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js > 62e149a > plasmoidviewer/qmlpackages/containment/contents/config/main.xml d889999 > plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml > b23e098 > plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0 > plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710 > plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217 > plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3 > plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION > plasmoidviewer/view.h 0e2e48c > plasmoidviewer/view.cpp fc008b0 > > Diff: http://git.reviewboard.kde.org/r/114493/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
