----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114589/#review46067 -----------------------------------------------------------
Ship it! Thanks for both the fix and the documentation! - Marco Martin On Dec. 21, 2013, 8:01 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114589/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2013, 8:01 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > > Fix memory issues in MouseEventListener > > Delete KDeclarativeMouseEvent when emitted > > Do not leak KDeclarativeMouseEvent press and hold events when the mouse > moves. > > Do not create KDeclarativeMouseEvent when the mouse is hovered. It's > pointless. > > > Add documentation for MouseEventListener > > Add a simple manual test for MouseEventListener > > > Diffs > ----- > > src/declarativeimports/qtextracomponents/mouseeventlistener.h 7940846 > src/declarativeimports/qtextracomponents/mouseeventlistener.cpp 8f925dd > src/declarativeimports/qtextracomponents/tests/mouseeventlistenertest.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114589/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
