----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114912/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-framework Description ------- Replace use of KSharedPtr with a QWeakPointer and QSharedPointer in Plasma::Svg. This removes the last dependency from plasma-framework on kde4support. This change is a bit more involved than other kde4support removals because QSharedPointer does not provide a count() method. I therefore reworked the code to store the SharedSvgRenderer as a QWeakPointer in s_renderers, making it possible to detect when the last one goes away by creating a QWeakPointer guard in SvgPrivate::eraseRenderer(). Diffs ----- CMakeLists.txt 8b60011 src/plasma/CMakeLists.txt aced599 src/plasma/private/svg_p.h 5fdebf3 src/plasma/svg.cpp 6542b34 Diff: https://git.reviewboard.kde.org/r/114912/diff/ Testing ------- Thanks, Aurélien Gâteau
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
