----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115301/#review48233 -----------------------------------------------------------
src/shell/osd.cpp <https://git.reviewboard.kde.org/r/115301/#comment34117> class KDECLARATIVE_EXPORT QmlObject : public QObject This isn't a window of any sort; It's a bit of a poor name. src/shell/osd.cpp <https://git.reviewboard.kde.org/r/115301/#comment34118> This seems a bit risky? Is it relying on the root item being a Plasma.Dialog? Given we load from a look & feel package which anyone can alter at least qFatal with an appropriate error message. Probably do this on show() as that's going to be called before hide(). - David Edmundson On Jan. 24, 2014, 4:40 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115301/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 4:40 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > As we decided to make the OSD available only for certain things, the API is > intentionally limited to very particular set of things. The list is not > complete yet I believe, but I'd like to get comments on the general design > and state. > > Also as it's not a public service, I left it under org.kde.plasma_shell on > D-Bus. Makes sense? Does not? Should it be standalone at eg. org.kde.osd? > > Note: This still needs patches in kwin. > > > Diffs > ----- > > src/shell/shellmanager.cpp 1188b48 > src/shell/osd.cpp PRE-CREATION > src/shell/osd.h PRE-CREATION > src/shell/CMakeLists.txt 5c4b360 > > Diff: https://git.reviewboard.kde.org/r/115301/diff/ > > > Testing > ------- > > Can be invoked using qdbus from command line. Works rather well. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
