----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115348/#review48465 -----------------------------------------------------------
Ship it! src/declarativeimports/qtextracomponents/mimedatabase.h <https://git.reviewboard.kde.org/r/115348/#comment34266> If you return a map, it needs documenting on what the keys will be. Long term this shouldn't be part of plasma but elsewhere. I guess this relates to discussions on frameworks at the moment. It can move later. - David Edmundson On Jan. 28, 2014, 2:01 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115348/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 2:01 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Makes it possible to figure out mimetypes from QML. > > > Diffs > ----- > > src/declarativeimports/qtextracomponents/CMakeLists.txt 0ae9e17 > src/declarativeimports/qtextracomponents/mimedatabase.h PRE-CREATION > src/declarativeimports/qtextracomponents/mimedatabase.cpp PRE-CREATION > src/declarativeimports/qtextracomponents/qtextracomponentsplugin.cpp > d3f8149 > > Diff: https://git.reviewboard.kde.org/r/115348/diff/ > > > Testing > ------- > > Works on my WIP changes for the QuickShare (was pastebin) plasmoid. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
