----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52440 -----------------------------------------------------------
Ship it! Looks good, please go ahead and push it. When pushing, take care to- 1. Give a good commit message, explaining in brief what this commit does. 2. On a separate line, say "BUG: <number>" (without quotes) so that this commit closes the bug. 3. On a separate line, say "REVIEW: <number>" (without quotes) so that this commit closes the review as submitted. - Shantanu Tushar On March 9, 2014, 2:33 p.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116656/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 2:33 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Bugs: 331820 > http://bugs.kde.org/show_bug.cgi?id=331820 > > > Repository: plasma-mediacenter > > > Description > ------- > > When you delete a media from playlist while searching, often some other media > gets deleted. > > > Diffs > ----- > > mediaelements/playlist/PlaylistDelegate.qml 644bfd0 > mediaelements/playlist/Playlist.qml dbca104 > libs/mediacenter/filterplaylistmodel.cpp e6f7053 > libs/mediacenter/filterplaylistmodel.h aa1284b > > Diff: https://git.reviewboard.kde.org/r/116656/diff/ > > > Testing > ------- > > Deleted some media, when filter text was not empty. Now, the correct media is > getting deleted from the playlist. > > > Thanks, > > Ashish Madeti > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
