> On March 7, 2014, 10:52 a.m., David Edmundson wrote: > > qml/CompositingView.qml, line 76 > > <https://git.reviewboard.kde.org/r/116648/diff/1/?file=252688#file252688line76> > > > > This is really liable to break. > > If someone were to add an entry in the earlier in the model and > > everything will break without any warning at compile time. > > > > give we have a compositingTypeForIndex can we use that to turn on/off > > the other options?
addressed in https://git.reviewboard.kde.org/r/116690/ - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52327 ----------------------------------------------------------- On March 9, 2014, 2:53 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116648/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 2:53 p.m.) > > > Review request for kwin, Plasma and Antonis Tsiapaliokas. > > > Repository: kwin-compositing-kcm > > > Description > ------- > > Split into one KCM for Desktop Effects and one for Compositing > > Let's try getting the KCM a little bit less scary by properly > hiding everything the user doesn't have to care about. The prominent > desktop effects KCM only contains the list of all the effects which > can be configured and nothing else. Only exception is the disabled > check after failed GL to make this easier for the user. > > All the "advanced" settings are moved into a new KCM called > "Compositing" which is put under the hardware component in > systemsettings. This contains all advanced settings including > * whether compositing is enabled at all > * backend > * animation speeed > * scale filter > * unredirect fullscreen > * color correction > > > Diffs > ----- > > qml/main.qml d22dd08da529df938d99ff9d43f52f7b33a7f2d3 > qml/OpenGLErrorView.qml PRE-CREATION > qml/main-compositing.qml PRE-CREATION > qml/EffectView.qml c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2 > qml/CompositingView.qml PRE-CREATION > model.cpp 2b25fe04ccacf0fb719956b1b5fa0267611747e6 > model.h 2efa2a9df63ee7f7ec483df004ff9530fdc0f852 > main.cpp 5c68722961be9b8a0a48f3221df7c033ba3cf946 > kwincompositing.desktop 88ecf46b393df947d6b59ce53c924a82fc65756a > kcmkwineffects.desktop PRE-CREATION > CMakeLists.txt d70672f3937fb44240c2c2d8e2a8d90c67890e2a > > Diff: https://git.reviewboard.kde.org/r/116648/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > New advanced compositing KCM > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png > New effects KCM > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png > Effects KCM with GHNS button > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/f467b643-5341-4cfe-8282-eeea93bc98e5__kcmeffects.png > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
