----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116824/#review52999 -----------------------------------------------------------
In general I don't see why N clicks of a button won't repeat the action N times, sounds very logical to me. So not sure if it needs "fixing". browsingbackends/localfiles/localfilesabstractbackend.cpp <https://git.reviewboard.kde.org/r/116824/#comment37294> Global vars are bad, avoid. browsingbackends/localfiles/localfilesabstractbackend.cpp <https://git.reviewboard.kde.org/r/116824/#comment37293> Where is model1 set? I don't see it being assigned any value ever. - Shantanu Tushar On March 15, 2014, 6:58 p.m., Harshit Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116824/ > ----------------------------------------------------------- > > (Updated March 15, 2014, 6:58 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > The "Play All" button when clicked multiple times, was adding all the media > multiple times onto the playlist. This is resolved, and now it adds the media > only single time if the button is clicked multiple times. > > > Diffs > ----- > > > browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.cpp > 8aaddcc > browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 > > Diff: https://git.reviewboard.kde.org/r/116824/diff/ > > > Testing > ------- > > It has been tested with the local files in Music as well as the Videos > section. Patch found to be consistent. > > > Thanks, > > Harshit Agarwal > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
