> On March 17, 2014, 11:19 p.m., Àlex Fiestas wrote: > > I can't test it but it looks good. > > > > I wonder, can this be put in powerdevil from 4.13? > > Sebastian Kügler wrote: > The DBus interface of plasma-shell is new, so if it's in powerdevil, it > will only work if plasma-shell is running, not plasma-desktop. If that's the > case you want to specifically support, yes, it can be done. Up to you I'd say > if it's a sensible idea.
No I think you got confused a bit, this can be put in powerdevil 4.13 just fine, this patch is purely about removing the call "showBrightnessOSD()" which then contains the OSD implementation (or using the DBus interface in plasma-shell). So should be fine and I can do that change for 4.13 (or 4.11.x rather). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116796/#review53271 ----------------------------------------------------------- On March 16, 2014, 10:20 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116796/ > ----------------------------------------------------------- > > (Updated March 16, 2014, 10:20 p.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Repository: kde-workspace > > > Description > ------- > > As discussed at the Plasma sprint, we want to show the OSD only on user input > as a way of feedback to the action the user just did. > > > Diffs > ----- > > powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 228645b > > Diff: https://git.reviewboard.kde.org/r/116796/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
