----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117983/#review57231 -----------------------------------------------------------
This review has been submitted with commit e911838bd72f48dce8e8b45395d6f9069f657d91 by Shantanu Tushar to branch master. - Commit Hook On May 4, 2014, 6:58 a.m., Shantanu Tushar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117983/ > ----------------------------------------------------------- > > (Updated May 4, 2014, 6:58 a.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > The code around fetching/storing covers and other such images from remote > sources and local files had become quite confusing over time. This patch > removes unnecessary things and moves methods to the right places. > > > Diffs > ----- > > libs/mediacenter/CMakeLists.txt 1072799 > libs/mediacenter/pmccoverartprovider.h a4aeb83 > libs/mediacenter/pmccoverartprovider.cpp c68afa2 > libs/mediacenter/pmcimagecache.h 631d5bd > libs/mediacenter/pmcimagecache.cpp d1b57b5 > libs/mediacenter/pmcimageprovider.h e584810 > libs/mediacenter/pmcimageprovider.cpp 4198f56 > libs/mediacenter/pmcmetadatamodel.cpp a58a57b > libs/test/lastfmimagefetchertest.cpp b0fcf6f > mediaelements/mediaplayer/MusicStats.qml 178a37d > mediaelements/popupmenu/PopupMenu.qml 1c87926 > shells/newshell/mainwindow.cpp 764b228 > > Diff: https://git.reviewboard.kde.org/r/117983/diff/ > > > Testing > ------- > > Tested the following things- > * Album and Artist cover art > * Cover in MusicStats.qml when playing from a file > * Thumbnails in All Videos > > > Thanks, > > Shantanu Tushar > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
