----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57402 -----------------------------------------------------------
I'm unsure about the isMalformed check. Did you try the unittest? Does it still pass without that check? kurifilter-plugins/shorturi/kshorturifilter.cpp <https://git.reviewboard.kde.org/r/118017/#comment39947> Better use QUrl u = QUrl::fromLocalFile(path) then. - David Faure On May 6, 2014, 12:42 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118017/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 12:42 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: kio-extras > > > Description > ------- > > With QUrl we have to set the scheme manually, seems like KUrl defaulted to > file://. > > Also removed the !isMalformed in the codition, QUrl("~") is malformed, > whereas KUrl("~") was not > > > Diffs > ----- > > kurifilter-plugins/shorturi/kshorturifilter.cpp > 58f3435f7599acf692a082d216a0c58684bcf8b6 > > Diff: https://git.reviewboard.kde.org/r/118017/diff/ > > > Testing > ------- > > Added unit test in KIO, works now > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
