> On May 26, 2014, 4:43 p.m., Alexander Potashev wrote: > > src/declarativeimports/calendar/qml/MonthView.qml, line 106 > > <https://git.reviewboard.kde.org/r/118328/diff/1/?file=275094#file275094line106> > > > > Isn't adding of a fixed string (", ") a word puzzle? > > > > > > http://techbase.kde.org/Development/Tutorials/Localization/i18n_Mistakes#Pitfall_.232:_Word_Puzzles
Kinda. I'm thinking about getting rid of that part, constructing proper date out of it and having it fully formatted by QLocale... - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/#review58488 ----------------------------------------------------------- On May 26, 2014, 4:25 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118328/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 4:25 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Currently we have 3 applets using the calendar grid and all of them put the > extra heading to the calendar. We also offer ways to change the displayed > month so we should also show /which/ month is the current one displayed, > implicitly. > > I'll remove the special headers from the plasmoids afterwards. > > > Diffs > ----- > > src/declarativeimports/calendar/qml/MonthView.qml 706952b > > Diff: https://git.reviewboard.kde.org/r/118328/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
