> On June 19, 2014, 8:42 p.m., David Edmundson wrote: > > Note: The property names don't line up 100% in the merge. > > > > flickableItem has now become contentItem (which is a default property) > > > > All instances in plasma-workspace/plasma-desktop are now updated. > > Kai Uwe Broulik wrote: > That doesn't matter: "flickableItem: The flickableItem of the ScrollView. > If the contentItem provided to the ScrollView is a Flickable, it will be the > contentItem."
Ah, nevermind, flickableItem is only for accessing. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60561 ----------------------------------------------------------- On June 19, 2014, 6:09 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114283/ > ----------------------------------------------------------- > > (Updated June 19, 2014, 6:09 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Use QtQuickControls ScrollView internally > > Flickable has a very odd API in which contentHeight can't be trusted. we need > to update our ScrollBars/ScrollArea to make use of the new > originX and originY in order to fix a lot of bugs that we currently see with > scrollbars. > > Instead of doing that, by porting to use QtQuick Controls we get all > these bug fixes as well as _significantly_ reducing our code. > > Having a separate logic vs UI, makes things (IMHO) easier to read. > > I don't expect to merge this as-is; I haven't included the plasma > feature that creates a SectionScroller if the content is a listview, but > that should be viable. As far as I know all other features (keyboard > controls / hiding buttons on touch screens) are still kept. > > Files removed are as indication as to long term changes from making this > change, in order to do that we need to port all users from ScrollBars -> > ScrollArea. (which is worth doing anyway IMHO) > > > Diffs > ----- > > src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 860c0e7 > src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114283/diff/ > > > Testing > ------- > > Widget Explorer in plasma-shell looks exactly as before. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
