----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60608 -----------------------------------------------------------
This review has been submitted with commit d3de99eb1e59c30a7e0fa53c81dcf0af5cb35d67 by Vishesh Handa to branch master. - Commit Hook On June 20, 2014, 2:35 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118849/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 2:35 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > The popup dialog can currently never be resized, so it doesn't make > sense to record its height in a config file. Additionally, this also > causes problems when applet writers change the size of their plasmoid. > Since the old size is saved in the config file, it is shown with the old > dimensions instead of the new ones. > > When we implement dialog resizing at that time we can propogate a signal > which says that the applet has been manually resized and save it in a config > file. Though even that could be buggy since the plasmoid could later be much > smaller. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp a6e91f7 > src/plasmaquick/private/appletquickitem_p.h 8b8010a > > Diff: https://git.reviewboard.kde.org/r/118849/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
