> On June 21, 2014, 1:13 p.m., Celeste Lyn Paul wrote: > > Ship It!
This is great and follows one of the recommendations I made in my KDE Notifications research. - Celeste Lyn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60660 ----------------------------------------------------------- On June 20, 2014, 1:28 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118796/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 1:28 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This prevents some apps to spam lots of notifications when all it needs is > actually just one single notification. > > Imagine you're switching songs in your playlist quickly and each song change > sends new notification, but when > you get to the tenth song, you still see the notification from the 3rd song > (because timeouts) and you don't > really care about all those songs changes still in the queue as you see it in > the playlist anyway. > > So this patch limits certain apps to have only one single notification which > is always updated. So far > Clementine and Spotify is there. Switching songs or changing playback status > creates only one single popup. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32 > applets/notifications/plugin/notificationshelper.cpp c5a1082 > dataengines/notifications/notificationsengine.h df0d3ca > dataengines/notifications/notificationsengine.cpp aaf6079 > > Diff: https://git.reviewboard.kde.org/r/118796/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
