----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61694 -----------------------------------------------------------
GenericDataLocation + env is polluting the global namespace. Imagine if gnome did the same... My suggestion is GenericConfigLocation + "/startkde/env/" or GenericConfigLocation + "/kde-workspace/env/". Yes, this means adjusting the KCM as well, of course. startkde/startkde.cmake <https://git.reviewboard.kde.org/r/119145/#comment42933> concatenation doesn't really need sed. - David Faure On July 6, 2014, 12:52 p.m., Luca Beltrame wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119145/ > ----------------------------------------------------------- > > (Updated July 6, 2014, 12:52 p.m.) > > > Review request for KDE Frameworks, Plasma and David Faure. > > > Bugs: 333793 > https://bugs.kde.org/show_bug.cgi?id=333793 > > > Repository: plasma-workspace > > > Description > ------- > > Currently env and shutdown scripts in startkde are not run due to the way > kf5-config is used. There is no more $KDEHOME, so proper paths aren't being > found. > > This patch moves things to qtpaths, putting things under GenericDataLocation > + "env" (or "shutdown"). This is what the plasma-desktop KCM does, but > according to the discussion in [1] it may change depending on the outcome. > > [1] http://lists.kde.org/?t=140464151200002&r=1&w=2 > > > Diffs > ----- > > startkde/startkde.cmake 24610f4 > > Diff: https://git.reviewboard.kde.org/r/119145/diff/ > > > Testing > ------- > > > Thanks, > > Luca Beltrame > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
