> On July 15, 2014, 4:04 a.m., Sebastian Kügler wrote: > > Neato! > > > > There's one issue in the dimensions calculation of the painted rect as far > > as I can see. It's not visible, but would be nice to correct (or make sure > > that I am wrong). Otherwise, this can go in. > > > > Have you tried the effect on the loading time of the calendar, by the way? > > I can imagine this is quite a dramatic improvement compared to the state of > > about a week ago.
I haven't really measured it as this machine is a beast so it was always rather fast. Would be interesting if someone with slower machine could test and report. > On July 15, 2014, 4:04 a.m., Sebastian Kügler wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, line 58 > > <https://git.reviewboard.kde.org/r/119283/diff/2/?file=290254#file290254line58> > > > > + root.borderWidth > > > > The last cell has two borders here. Can you verify? Same goes for the > > height. > > Sebastian Kügler wrote: > grmblz, htmlification outsmarted me: has to be " ... + root.borderWidth". You are correct and I even had it that way originally, but rather than actual width this is the X coord where the line will stop and as it starts from (0,0), adding that one additional border resulted in off-by-1 error (the real width is say 400, so it goes from 0,0 to 399,0). But it should indeed be " ... + root.borderWidth - 1". I'll add a comment and fix. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119283/#review62365 ----------------------------------------------------------- On July 14, 2014, 11:46 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119283/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 11:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > This patch simplifies the grid a bit more by using Canvas instead of > Rectangles, so actually lowering the number of Items needed to create the > grid from 16 to just 1. > > It works pretty neatly with no junctions problem at all. > > > Diffs > ----- > > src/declarativeimports/calendar/qml/DayDelegate.qml d626441 > src/declarativeimports/calendar/qml/DaysCalendar.qml 1249de2 > src/declarativeimports/calendar/qml/MonthView.qml 4946635 > > Diff: https://git.reviewboard.kde.org/r/119283/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot before/after > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/14/e744e403-89ff-4947-95eb-3ade4823ebb5__plasma_cal_canvas.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
