----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/ -----------------------------------------------------------
(Updated July 25, 2014, 10:14 a.m.) Review request for Plasma. Changes ------- Adopt some changes by David. Escentially uses the QImage itself to get the image hash rather than using the image description, so it keeps things simpler. Also we don't need to worry about themes changing, because this will take care of itself. Repository: plasma-framework Description ------- Create a cache that has pointers to all the textures that we've generated, so in case we have one already created, we can re-use it. Diffs (updated) ----- src/declarativeimports/core/framesvgitem.cpp 323b06b src/declarativeimports/core/iconitem.cpp 38012cc src/declarativeimports/core/svgitem.cpp eccff55 src/declarativeimports/core/svgtexturenode.h 21b9b2f src/desktoptheme/air/widgets/lineedit.svgz 8b3a123 Diff: https://git.reviewboard.kde.org/r/119425/diff/ Testing ------- see the qDebug (to be removed before commit). plasmashell 2> out $ grep s_cache out | grep ": miss" | wc -l 342 $ grep s_cache out | grep ": hit" | wc -l 126 So still having 3 times more hits than miss, so there's big room for improvement. Good news is that with this, we get a ~25% of memory and bandwidth save, in a per-item basis. Thanks, Aleix Pol Gonzalez
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
