----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119841/#review64833 -----------------------------------------------------------
CMakeLists.txt <https://git.reviewboard.kde.org/r/119841/#comment45327> Why do you need to have major, minor and patch separately? Also we can probably use the project(VERSION) argument for this, it would end up something like: project(systemsettings VERSION 5.95.0) without any weird set calls. - Aleix Pol Gonzalez On Aug. 19, 2014, 11:06 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119841/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 11:06 a.m.) > > > Review request for Plasma. > > > Repository: systemsettings > > > Description > ------- > > standardise the way version numbers are set in plasma > > > Diffs > ----- > > CMakeLists.txt 5c09e134f02f95bf191e36209e60bd9c6b13a26c > app/CMakeLists.txt 05fe8e3f1b89034f6c55455b080b652ab30f01e3 > app/main.cpp 46ec0bf4a217a6b94410d2192609f0444c82ca17 > > Diff: https://git.reviewboard.kde.org/r/119841/diff/ > > > Testing > ------- > > compiled and ran systemsettings5 --version > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
