> On Aug. 11, 2014, 6:35 a.m., Martin Gräßlin wrote: > > I highly suggest to revert this change. Enforcing GLES means limiting to > > GLES (it's a subset after all) and also not all drivers do support GLES - > > that's still the smaller part. We are calling for lots of trouble if we go > > this route. > > > > I suggest to enforce core profile instead. > > Aleix Pol Gonzalez wrote: > We discussed it with Marco, apparently this breaks on nvidia. > > I'm fine with reverting it (both plasmashell and on krunner) or with > if'ing the cases where it doesn't work. > > Martin Gräßlin wrote: > Requesting GLES on a desktop system just feels very wrong and from KWin > experience: don't even think about ifdefing. For desktop usage I would > suggest to try using QSurfaceFormat::setProfile. > > Alexander Richardson wrote: > By the way this causes the build to fail with Qt 5.4, > QQuickWindow::setDefaultFormat was changed to > QSurfaceFormat::setDefaultFormat() (see > https://git.reviewboard.kde.org/r/119913/ )
It's been reverted since anyway. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119524/#review64219 ----------------------------------------------------------- On July 29, 2014, 4:15 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119524/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 4:15 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > When trying to reduce memory usage in plasma shell, we realized that one of > the reasons we got such big memory footprint was actually the intel driver > (on intel systems, that is). After some investigation, David found out we > were going through some memory-consuming path [1]. A way to workaround it is > by using only OpenGLES. Everything still works here after this patch, so it > seems to be a good change to get in. > > This change needs Qt 5.4, to get the new API that lets us enforce a > QSurfaceFormat, hence having it ifdef'd. > I'm quite unaware of problems we might find. Knowing we probably want to work > in different embedded devices, suggests that OpenGLES on all platforms sounds > like a safe bet. > > [1] http://comments.gmane.org/gmane.comp.video.mesa3d.devel/60848 > > > Diffs > ----- > > shell/main.cpp e34578d > > Diff: https://git.reviewboard.kde.org/r/119524/diff/ > > > Testing > ------- > > I'm using it now, without visible problems. Now we see no trace of i915 in > the massif reports. > > > File Attachments > ---------------- > > before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/5a6beb4f-24c0-4cee-a7a2-038385e35119__plasma-massif-opengl.png > after > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/28/fc301ff5-cb1d-4654-a57f-82990220c8e3__plasma-massif-opengles.png > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
