----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review65108 -----------------------------------------------------------
Ship it! One monsterous bug below. Make sure to fix it. applets/notifications/package/contents/ui/NotificationPopup.qml <https://git.reviewboard.kde.org/r/119916/#comment45486> use a >= just for future proofing applets/notifications/plugin/notificationshelper.cpp <https://git.reviewboard.kde.org/r/119916/#comment45487> = 0; otherwise in non debug builds you're going to get garbage - David Edmundson On Aug. 23, 2014, 11:19 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119916/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2014, 11:19 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Since the port of the Button component to QQC Button, the button height > cannot be set anymore, therefore the height of the popup now needs to be > higher when there are three actions. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationPopup.qml 489fbd1 > applets/notifications/plugin/notificationshelper.cpp 783c0e4 > > Diff: https://git.reviewboard.kde.org/r/119916/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/23/826a7f99-31f9-47e6-ba58-82ba523f5728__notifications-3actions.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
