----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119965/#review65399 -----------------------------------------------------------
Ship it! I was definitely bothered by the dependency from ktexteditor, +1 shell/interactiveconsole.h <https://git.reviewboard.kde.org/r/119965/#comment45694> Could this be an enum? - Marco Martin On Aug. 28, 2014, 8:17 a.m., Aaron J. Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119965/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 8:17 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This move the KTextEditor dependency out of plasmashell and into a QML > component which uses it. This allows plasmashell to carry fewer dependencies > while at *runtime* be able to appropriately address different form factors. > It also moves the responsibility for showing the interactive scripting > console to the shell package which can elect not to provide such a thing, > allowing the shell to determine whether there is a console or not and what > form it takes. > > Note that this also moves the widgetexplorer into a common components > directory where both it and the interactive console are put into a single > plugin. This may want to be changed in future to allow separate plugins to be > shipped, but this is better for performance and until shown necessary may as > well be this way. > > This relies on a one-liner patch to plasma-framework adding the interactive > console QML file key to the shell package structure. I'm not going to bother > with a review request for that, but will push it before pushing this. > > > Diffs > ----- > > CMakeLists.txt 6642d780aabe1777cb0457bb9b04e42c72358c9f > components/BatteryIcon.qml > components/CMakeLists.txt 07c48745652d7ec02147c2314ca08766a386f6b2 > components/qmldir > components/shellprivate/CMakeLists.txt PRE-CREATION > components/shellprivate/Messages.sh PRE-CREATION > shell/CMakeLists.txt 4b1dd664c4eae6dbb1832c54411140ce7c11038d > shell/interactiveconsole.h d3af64bf456de60140f8a8efd4a4655ba5c6b6dd > shell/interactiveconsole.cpp 7096033a3076472a969b9bb19c43053d5e9977f8 > shell/scripting/desktopscriptengine.h > dd097d228b3982910346fe6f07412fd0137fc372 > shell/scripting/desktopscriptengine.cpp > 37d138744dd2b56e6b34cdd20f1eef5c79361a40 > shell/scripting/scriptengine.h ffb0cbfb435d224f48cd715b66e94449114642db > shell/widgetexplorer/kcategorizeditemsviewmodels_p.h > shell/widgetexplorer/openwidgetassistant.cpp > shell/widgetexplorer/openwidgetassistant_p.h > shell/widgetexplorer/plasmaappletitemmodel.cpp > shell/widgetexplorer/plasmaappletitemmodel_p.h > shell/widgetexplorer/plasmoids.knsrc > shell/widgetexplorer/qmldir d808b18cfea863d6910df0cb922eb8e6e1c2bda9 > shell/widgetexplorer/widgetexplorer.h > shell/widgetexplorer/widgetexplorer.cpp > shell/widgetexplorer/widgetexplorerplugin.h > 3ee262e52d16feab35999c7963fc06b8653347a0 > shell/widgetexplorer/widgetexplorerplugin.cpp > f21178beb7279a851c4637fdc66d382d97f1bab9 > shell/scripting/scriptengine.cpp 4db966f81d2cdaade21b07165ce6bfdd411c2366 > shell/shellcorona.h b032803fe7286ba007a47a80065c6fbbb40a9709 > shell/shellcorona.cpp c5447c24a2de5f42cda978e5690a210e15d80b76 > shell/widgetexplorer/CMakeLists.txt > dd0ea97045417245ac0b2c1a870147f2ff34e4ec > shell/widgetexplorer/Messages.sh 3beeea4b3eae941ad88b66ec9af667915b66e950 > shell/widgetexplorer/kcategorizeditemsviewmodels.cpp > > Diff: https://git.reviewboard.kde.org/r/119965/diff/ > > > Testing > ------- > > Run with a shell package with InteractiveConsole.qml, used the console to run > scripts, opened and closed it, etc. > > > Thanks, > > Aaron J. Seigo > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
