> On Aug. 30, 2014, 12:39 p.m., David Edmundson wrote: > > applets/systemloadviewer/package/contents/ui/GeneralSettings.qml, line 92 > > <https://git.reviewboard.kde.org/r/120002/diff/1/?file=308583#file308583line92> > > > > Can you do Layout.rowSpan: 2 > > > > instead of putting the spacer (line 96 in this diff)
I commented on the same problem in https://git.reviewboard.kde.org/r/120002/diff/1/?file=308583#file308583line74 The problem is that I can't get the same result when doing it that way. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120002/#review65540 ----------------------------------------------------------- On Aug. 30, 2014, 12:20 p.m., Martin Yrjölä wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120002/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2014, 12:20 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: kdeplasma-addons > > > Description > ------- > > More polish by courtesy of the VDG. > > > Diffs > ----- > > applets/systemloadviewer/package/contents/ui/ColorPicker.qml > 1b3c88233da75b9d001a0159dd4298d41f7d307c > applets/systemloadviewer/package/contents/ui/ColorSettings.qml PRE-CREATION > applets/systemloadviewer/package/contents/ui/GeneralSettings.qml > fd719d5f2afed8c630fd6a1281f6ddda674b60c2 > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml > 9e101f8fd68602495366c0dc8226927a572e0267 > applets/systemloadviewer/package/contents/config/config.qml > 570cc77ece3ed0bf84d89e45426773954f95d409 > applets/systemloadviewer/package/contents/config/main.xml > 5e38045eb369e029564abf973827eb84534eb9f4 > > Diff: https://git.reviewboard.kde.org/r/120002/diff/ > > > Testing > ------- > > Mostly cosmetic changes, but I tested that the options does still work. > > > File Attachments > ---------------- > > General settings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/7ed9b718-93bd-4936-98dd-7a58b8b51128__2014-08-30-142153_361x169_scrot.png > Color settings with enabled manual color settings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8e2367fd-9f44-4bd2-87fe-df5ffbd746be__2014-08-30-143838_256x304_scrot.png > Color settings with disabled manual color settings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8399a4e1-7fa0-4369-ae30-cadbe455d2bb__2014-08-30-143853_254x304_scrot.png > > > Thanks, > > Martin Yrjölä > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
