----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235/#review66756 -----------------------------------------------------------
Do all of the tests now pass? src/plasmaquick/dialog.cpp <https://git.reviewboard.kde.org/r/120235/#comment46559> I'm wondering if it makes sense to introduce a new option for resizeOrigin instead of using Undefined? src/plasmaquick/dialog.cpp <https://git.reviewboard.kde.org/r/120235/#comment46560> I'm not okay with this code. It's very very hard to understand why this if is there. The reason I think it's there - resizeEvent changes the size of the mainItem which will result in this slot being called. In order to avoid doing anything we're guarding the resizeOrigin. How about we disconnect the signals so that when this slot is actually called it should really do something? src/plasmaquick/dialog.cpp <https://git.reviewboard.kde.org/r/120235/#comment46561> Again, I'm not sure what the point of setting these values is, does this function call a slot which in turn checks resizeOrigin? It doesn't seem like it. src/plasmaquick/dialog.cpp <https://git.reviewboard.kde.org/r/120235/#comment46562> ditto - Vishesh Handa On Sept. 17, 2014, 4:03 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120235/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 4:03 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > A dialog can be resize for two reasons: the mainItem size changes, or the > dialog size changes. > > the first can happen programmatically, caused by the Layout, or just by > assigning the width. > > the second can be caused either programmatically, assigning the size of the > dialog or externally by the windowmanager, that is the only one theat in the > end has the only final control of the window size > > > Diffs > ----- > > src/plasmaquick/dialog.cpp 79a871b > tests/dialog_minWidthHeightRepositioning.qml 37bd622 > > Diff: https://git.reviewboard.kde.org/r/120235/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
