> On Sept. 16, 2014, 4:01 p.m., Hugo Pereira Da Costa wrote: > > ok, ship it, then :) > > in the meanwhile I'll try compile a more recent Qt5 version (which branch > > do you use ? stable ?) > > and then I'll go debug breeze and oxygen (I'm actually eager to) > > David Edmundson wrote: > "stable" shouldn't be used. > The right branch name is "5.4". > > I think the biggest issues aren't the fault of the style. Fusion is just > as bad (if anything worse) > > Hugo Pereira Da Costa wrote: > mmm. That is what I am using (5.4 branch) > but I have not pulled it for quite some time though. > Ok. Will give it a shot. Thx > > Hugo Pereira Da Costa wrote: > for the record: > I've updated my qt5.4, dpi scaling now works here (great) and I'll submit > review to fix, among other things, kpagewidget, klineedit, etc. > There are few things to be fixed in breeze also, > and of course, for oxygen, all tilesets (which do not benefit for the > extra pixels as of now)
urgh it is is a KLineEdit. Instead of fixing that, lets work on moving oxygen-demo away from kdelibs4support onto QLineEdit. (hopefully that works better..) Ping if you want some help on any dpi things. Maybe we can/should make a Kanboard for it? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120234/#review66683 ----------------------------------------------------------- On Sept. 16, 2014, 4:23 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120234/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 4:23 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > ------- > > This is the flag that application developers need to set if they want to > support smooth scaling. > > From a QStyle perspective we need to support both having this set and > not set. The demo seems a good place to start testing and fixing. > > With QT_DEVICE_PIXEL_RATIO=2: > Without this flag everything looks blocky but is in the right place. > > With this flag, everything looks super smooth but some layout parts are > screwed. > > > Diffs > ----- > > kstyle/demo/main.cpp ed2f3b4 > > Diff: https://git.reviewboard.kde.org/r/120234/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
