-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120327/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

Fix crash in ImageWallpaper

When not in a package (i.e a lone image) the metadata file cannot be
loaded. This returns an invalid metadata (KPluginInfo) with isValid()
set to false but an invalid d pointer.


Diffs
-----

  wallpapers/image/backgroundlistmodel.cpp a667c10 

Diff: https://git.reviewboard.kde.org/r/120327/diff/


Testing
-------

In config to change the wallpaper click the remove button of one of your own 
images, it didn't crash.

It fixes it, but I'm not convinced it's the correct fix, we're still spewing 
warnings about the package being broken.


Thanks,

David Edmundson

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to