Hi all, since today I've been burned by this thing, i figured it's worth to send a quick FYI so that doesn't happen to anybody else (added to the wiki page too)
if you send as review request a commit in a branch, you may want one of the two possible behaviors: a) your branch is ready to be merged in master, you make a review request that when submitted will cause the merge on the remote master. b) you want to send a patch in a feature branch that you was looking at with somebody else, when submitted you want the patch committed in the feature branch, that not ready for merge yet. probably a less common usecase, but still, happens. let's say foo is the name of your branch if a) you do when in branch foo git push gerrit HEAD:refs/for/master if b) you do when in branch foo git push gerrit HEAD:refs/for/foo and please check in the gerrit web interface it says the proper branch you are actually expecting, before pressing submit and then screaming aaaaw, shit! as i did today ;) Cheers, Marco Martin _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
