> On Sept. 23, 2014, 11:22 a.m., David Edmundson wrote: > > applets/binary-clock/package/contents/ui/configGeneral.qml, line 58 > > <https://git.reviewboard.kde.org/r/120325/diff/1/?file=314632#file314632line58> > > > > in general ColumnLayout is better than Columns > > (from QtQuick.Layouts 1.1)
Fwiw, I can't make ColumnLayout dynamically relayout things when one of them changes height in animation while Column in the very same place just works... - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/#review67280 ----------------------------------------------------------- On Sept. 23, 2014, 12:56 a.m., Joseph Wenninger wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120325/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 12:56 a.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > port of the kde4 c++ based binary clock to kf5/qml only. It works on the > desktop, but some sizing/dot sizeing issues exist in the panels. At least it > is a start > > I'd like somebody to have a look at it to tell me, if I'm on the right way or > if I'm completely wrong > > > Diffs > ----- > > applets/binary-clock/binaryclock.h 5ae83dfff9c473bd484b99d49330093b6e091975 > applets/binary-clock/Messages.sh 40a3686fffcb2036d5baef6e3ab2ba58ff57a8f4 > applets/CMakeLists.txt 38751705f0b712ee8ce6861a7d437402be480873 > applets/binary-clock/CMakeLists.txt > b42a6e76752af3cc800ad5455ba0678a18a0ce45 > applets/binary-clock/package/contents/ui/BinaryClock.qml PRE-CREATION > applets/binary-clock/package/contents/ui/Dot.qml PRE-CREATION > applets/binary-clock/package/contents/ui/DotColumn.qml PRE-CREATION > applets/binary-clock/package/contents/ui/configGeneral.qml PRE-CREATION > applets/binary-clock/package/contents/ui/main.qml PRE-CREATION > applets/binary-clock/plasma-applet-binaryclock.desktop > 10bd99b0518873f819ae89c9e9b9e09d9eb3490e > applets/binary-clock/clockConfig.ui > 0c2cec7925dd9e1ff92d7cd9d99005dca20497b0 > applets/binary-clock/package/contents/config/config.qml PRE-CREATION > applets/binary-clock/package/contents/config/main.xml PRE-CREATION > applets/binary-clock/binaryclock.cpp > 75c4548588ff15e2316dd1c2e888ad8c07f7f78b > > Diff: https://git.reviewboard.kde.org/r/120325/diff/ > > > Testing > ------- > > It works on the desktop, but the dots are too small in the panel > > > Thanks, > > Joseph Wenninger > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
