----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120390/#review67529 -----------------------------------------------------------
Ship it! Thanks for this As gerrit mails do not get to plasma-devel (are they going anywhere else?), can I please ask people breaking things to send a short mail and/or fix all things? kthxbai - Martin Klapetek On Sept. 27, 2014, 6:22 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120390/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2014, 6:22 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > With the recent changes to the dialog class the sizing broke. > Using Layout.minimum{Width,Height} fixes the dialog not appearing. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationPopup.qml 63036f1 > > Diff: https://git.reviewboard.kde.org/r/120390/diff/ > > > Testing > ------- > > Ran knotificationdbustest and everything works as expected again, both > initial positioning as well as re-positioning due to a popup disappearing. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
