> On Sept. 27, 2014, 2:05 p.m., Martin Klapetek wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, lines 257-263 > > <https://git.reviewboard.kde.org/r/120358/diff/3/?file=315594#file315594line257> > > > > The result of both of these i18ncs is exactly the same; plus both > > comments are not true if it's used for the tooltip. > > > > However, changing the comments would violate string freeze. I'd suggest > > to possibly remove the i18nc altogether here as there are no localizable > > things (besides the order, but I guess we could live with that for a while).
I'm not sure what you are suggesting here? Remove the i18nc from the new string altogether? - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/#review67538 ----------------------------------------------------------- On Sept. 27, 2014, 1:51 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120358/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2014, 1:51 p.m.) > > > Review request for Plasma, Kai Uwe Broulik and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > DigitalClock: Add timezone information to digital clock tooltip. > > note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix > that before committing. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml > 2beae00d090dfe03e94c4223ba36546ffeda45f2 > > Diff: https://git.reviewboard.kde.org/r/120358/diff/ > > > Testing > ------- > > I ran it here with two timezones selected (Local and London). The date is > local date, but it was that way before anyway. The date next to each timezone > is the date for that timezone if dates are shown. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
