> On Oct. 17, 2014, 3:36 p.m., David Edmundson wrote: > > runners/locations/locationrunner.cpp, line 148 > > <https://git.reviewboard.kde.org/r/120623/diff/1/?file=320194#file320194line148> > > > > and if we don't find the folder in the entries? > > > > we'll end up returning "/" and then trying to open it? > > Vishesh Handa wrote: > No. The original path will be returned, and that will cause an error to > be shown.
Ok, I was a bit wrong about what would happen, but I don't think this code is quite right. Consider this scenario: I have a file /home/david/foo.txt. I try to open "/home/david/somefolder/foo.txt" (where somefolder doesn't exist) it wouldn't go into somefolder but silently fail and open /home/david/foo.txt Possibly a slightly contrived example, but plausible. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120623/#review68617 ----------------------------------------------------------- On Oct. 17, 2014, 3:32 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120623/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 3:32 p.m.) > > > Review request for Plasma. > > > Bugs: 333395 > https://bugs.kde.org/show_bug.cgi?id=333395 > > > Repository: plasma-workspace > > > Description > ------- > > See bug report > > > Diffs > ----- > > runners/locations/locationrunner.cpp 13035a9 > > Diff: https://git.reviewboard.kde.org/r/120623/diff/ > > > Testing > ------- > > Bug fixed. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel