----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/#review69299 -----------------------------------------------------------
Ship it! lookandfeel/contents/windowswitcher/WindowSwitcher.qml <https://git.reviewboard.kde.org/r/120850/#comment48453> property alias is cheaper lookandfeel/contents/windowswitcher/WindowSwitcher.qml <https://git.reviewboard.kde.org/r/120850/#comment48455> Then use FrameSvg not FrameSvgItem lookandfeel/contents/windowswitcher/WindowSwitcher.qml <https://git.reviewboard.kde.org/r/120850/#comment48452> You don't need this. You're clipping the child list view which fills the parent, and clipping is expensive. IIRC ScrollArea will automatically clip scroll contents, so you can get rid of both the explicit clip calls - David Edmundson On Oct. 28, 2014, 3:55 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120850/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 3:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Move KWin's window switcher "sidebar" to Look'n'Feel package > > > Diffs > ----- > > lookandfeel/contents/defaults 1dfe182e305f0a4ca2e0daad56a581efd68b930b > lookandfeel/contents/windowswitcher/WindowSwitcher.qml > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > > Diff: https://git.reviewboard.kde.org/r/120850/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
